-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auto pagination #10
Conversation
af45d84
to
7877d2b
Compare
7877d2b
to
af76ebd
Compare
I found on iOS unexpected onEndReached may be triggered, especially at first onFetch. Works well on Android. Another approach may be using onChangeVisibleRows. That would require a user provided function like
to see if last row becomes visible on screen. Just a thought, I haven't tested it yet. |
How to run it for ios ,when I run it in xcode, the xcode tell me "RCtRootView.h" file not found. |
@realaboo what as the issue with |
@faceyspacey I just found it unstable on iOS but did not dig into it. You can test it yourself with latest react native release. |
automatic infinite scroll as provided here really would make this package one of the best list view packages. it's the one missing feature that everyone has on their checklist when they go looking around for which of these list views to use. |
any word on when this will be merged? |
Hello, I didn't merge it because @realaboo said it was a just proof of concept and it was unstable on iOS. I don't have time to improve it but if someone can submit a pull request it will be merged. |
i created a PR fixing the issues with multiple fires of I'd say GiftedListVIew is ready for infinite scrolling! |
another thing: I think the prop should be called here's a search for a "infin": https://js.coach/react-native/generator-irrigate?search=infin As you can see, we aren't listed, but it's enough to bring up any component that has those consecutive characters in the readme. See the component "generator-irrigate" which only has the full word "infinite" in the readme. |
for anyone following this pull request, i did a lot more: ...basically, there were a lot more issues than just the initial load triggering |
@faceyspacey Thanks! |
This is just a proof of concept. Feel free to reject or modify.
Set autoPaginate={true} on the GiftedListView to enable auto pagination. onEndReachedThreshold could be used to tune the trigger of auto pagination.